Fixed override of the long time format for Australian locale #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation accidentally removed all other formats.
Current coverage is 76.89% (diff: 100%)@@ master #180 diff @@
==========================================
Files 14 14
Lines 1567 1567
Methods 0 0
Messages 0 0
Branches 288 288
==========================================
Hits 1205 1205
Misses 268 268
Partials 94 94
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an Australian user noticing errors due to missing "short" time format. As it turned out, every format except "long" was missing. The previous implementation accidentally removed all other formats.
This change is