Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pyicu import to suppress warnings #242

Merged
merged 1 commit into from
May 31, 2020
Merged

fix pyicu import to suppress warnings #242

merged 1 commit into from
May 31, 2020

Conversation

brian-from-quantrocket
Copy link
Contributor

@brian-from-quantrocket brian-from-quantrocket commented Mar 27, 2020

Newer versions of pyicu should be imported as

import icu 

whereas

import PyICU 

will print a warning.

This fix uses the preferred import if available and otherwise falls back to the older name.


This change is Reviewable

Copy link
Owner

@bear bear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@bear
Copy link
Owner

bear commented May 31, 2020

Thanks for the fix

@bear bear merged commit 50dc617 into bear:master May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants