-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce httpwg crate #173
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an codegen the rest actually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #157
This gets rid of h2spec, the custom coverage script, and instead uses httpwg, a new Rust crate that is similar to h2spec in spirit, but allows running cases as Rust test cases.
There's only 3 test cases ported over so far, the rest will come later. All tests run in parallel now, and TCP isn't involved at all when they're run as unit tests. Due to the structure of httpwg / httpwg-gen / httpwg-macros, it's possible to generate a CLI, too.
In time, httpwg may move to its own repository (or even change name). For now, it's being developed together with fluke, since it reuses some of the base code (
fluke-h2-parse
, for starters), much like h2spec uses Go's http2 (de)framer.