Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

dsra32 Special Case #58

Open
fuzzywalls opened this issue May 3, 2021 · 1 comment
Open

dsra32 Special Case #58

fuzzywalls opened this issue May 3, 2021 · 1 comment

Comments

@fuzzywalls
Copy link

I ran across a problem (?) with the special case for dsra32. When the function in data/languages/mips.sinc (line 251) is left with empty brackets API functions such as getOperandRefType(x) will return None when it should return an appropriate value. I copied the implementation above it (the non-special case for dsra32) and functionality worked as expected, for me anyway. Also, right-clicking and selecting "Instruction Info..." shows missing Input Objects and Results Objects.

From this instruction:
Screen Shot 2021-05-03 at 12 29 34 PM

Before populating the function:
Screen Shot 2021-05-03 at 12 25 03 PM

After populating the function:
Screen Shot 2021-05-03 at 12 24 02 PM

This is the only change I made to achieve that result:
Screen Shot 2021-05-03 at 12 27 56 PM

I didn't want to make this a pull request because I don't know enough about Ghidra internals to know if this change will break something else.

@beardypig
Copy link
Owner

Hey, I think you should make a PR regardless as it will be easier to review the change you're suggesting.

fuzzywalls added a commit to fuzzywalls/ghidra-emotionengine that referenced this issue May 10, 2021
…PI functionality did to work as intended with an empty function.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants