Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix php7対応 #56

Merged
merged 5 commits into from
Jul 10, 2018
Merged

fix php7対応 #56

merged 5 commits into from
Jul 10, 2018

Conversation

mokotiyo
Copy link
Contributor

  • セッションmemcached対応
    • memcache指定では正常に書き込みができなかったため(php7.2環境で動作確認)
  • リソースリンクでの無限ループを修正
  • onAutoload修正
    • HTML_Quickformに登録したHTML_QuickForm_RuleのClassをloadできるよう修正(HTML_Quickform内部でlowercaseに変換されてしまうためcase sensitiveなcomposerのautoloaderではloadできなかった)
    • プロジェクト外のクラスファイルを読み込むケースがあるためインクルードパスにあるファイルであればloadできるよう修正

mokotiyo added 4 commits July 3, 2018 15:03
HTML_QuickForm_RuleRegistryでclassがlowercaseに変換されてしまうため1文字目を大文字にしてから探すように変更
インクルードパスにあるファイルであればrequireするように変更
BEAR.php Outdated
if (file_exists($file)) {
require $file;
}
$includePath = explode(":", get_include_path());
foreach($includePath as $path){
if (file_exists($path . "/" . $file)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちらもDIRECTORY_SEPARATORで!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直しました!

@koriym koriym merged commit 4f6d440 into bearsaturday:0.10.x Jul 10, 2018
@koriym
Copy link
Contributor

koriym commented Jul 10, 2018

0.10.4としてリリースしました!
https://github.com/bearsaturday/BEAR.Saturday/releases/tag/0.10.4

@mokotiyo mokotiyo deleted the hotfix/php7 branch July 11, 2018 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants