Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NowPlaying] focus controls instead main menu (2) #989

Merged
merged 1 commit into from
Apr 15, 2023

Conversation

beatmasterRS
Copy link
Owner

No description provided.

@beatmasterRS beatmasterRS added Improvement Improvement of skin-sections or skin-code Kodi 20 Kodi 20 labels Apr 14, 2023
@beatmasterRS
Copy link
Owner Author

I think i've found a better way to refocus the player controls then in #984

@beatmasterRS
Copy link
Owner Author

@Nanomani refocus should work fine to the player controls after 5 seconds, if player controls are visible. Works with all slide out settings. maybe you can take a look and test? :)

@Nanomani
Copy link
Contributor

@Nanomani refocus should work fine to the player controls after 5 seconds, if player controls are visible. Works with all slide out settings. maybe you can take a look and test? :)

Seems working like expected to me. Tested with "Vertical/modern Multi Widgets Netflix" :)

Just the new settings "only hide menu items" disable in all case with "Vertical Multi Widgets Netflix" but not with "modern Multi Widgets Netflix".

Sorry but I don't see any difference what it must do with "modern Multi Widgets Netflix". :/

@beatmasterRS
Copy link
Owner Author

@Nanomani refocus should work fine to the player controls after 5 seconds, if player controls are visible. Works with all slide out settings. maybe you can take a look and test? :)

Seems working like expected to me. Tested with "Vertical/modern Multi Widgets Netflix" :)

Just the new settings "only hide menu items" disable in all case with "Vertical Multi Widgets Netflix" but not with "modern Multi Widgets Netflix".

Sorry but I don't see any difference what it must do with "modern Multi Widgets Netflix". :/

Thanks for testing :)

It is about hiding either the whole menu including the background or only the single menu items. This only affects the horizontal bottom menu, since this only has a background and date/time.

@beatmasterRS beatmasterRS merged commit 1645413 into master Apr 15, 2023
@beatmasterRS beatmasterRS deleted the nowplaying-patch-22 branch July 31, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Improvement of skin-sections or skin-code Kodi 20 Kodi 20
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants