fix(ios): message sent to deallocated instance (TheWidlarzGroup#1482)

* fix(ios): message sent to deallocated instance * chore: update changelog
beauner69 · Feb 14, 2019 · d8a2a9e · d8a2a9e
1 parent 4424774
commit d8a2a9e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ### next
 
 * Fix loading package resolved videos when using video-caching [#1438](https://github.com/react-native-community/react-native-video/pull/1438)
+* Fix "message sent to deallocated instance" crash on ios [#1482](https://github.com/react-native-community/react-native-video/pull/1482)
 
 ### Version 4.3.0
 * Fix iOS video not displaying after switching source [#1395](https://github.com/react-native-community/react-native-video/pull/1395)

diff --git a/ios/Video/RCTVideo.m b/ios/Video/RCTVideo.m
@@ -197,6 +197,7 @@ - (void)dealloc
   [self removePlayerLayer];
   [self removePlayerItemObservers];
   [_player removeObserver:self forKeyPath:playbackRate context:nil];
+  [_player removeObserver:self forKeyPath:externalPlaybackActive context: nil];
 }
 
 #pragma mark - App lifecycle handlers