Merge pull request TheWidlarzGroup#1360 from nickgzzjr/master

Only apply filter if filter is set
beauner69 · Dec 13, 2018 · e5bada9 · e5bada9
2 parents b2aa8c4 + a4a0c8a
commit e5bada9
Showing 1 changed file with 21 additions and 31 deletions.
diff --git a/ios/Video/RCTVideo.m b/ios/Video/RCTVideo.m
@@ -1268,39 +1268,29 @@ - (void)videoPlayerViewControllerDidDismiss:(AVPlayerViewController *)playerView
 }
 
 - (void)setFilter:(NSString *)filterName {
-
     _filterName = filterName;
-
     AVAsset *asset = _playerItem.asset;
-
-    if (asset != nil) {
-
-        CIFilter *filter = [CIFilter filterWithName:filterName];
-
-        _playerItem.videoComposition = [AVVideoComposition
-                videoCompositionWithAsset:asset
-             applyingCIFiltersWithHandler:^(AVAsynchronousCIImageFilteringRequest *_Nonnull request) {
-
-                 if (filter == nil) {
-
-                     [request finishWithImage:request.sourceImage context:nil];
-
-                 } else {
-
-                     CIImage *image = request.sourceImage.imageByClampingToExtent;
-
-                     [filter setValue:image forKey:kCIInputImageKey];
-
-                     CIImage *output = [filter.outputImage imageByCroppingToRect:request.sourceImage.extent];
-
-                     [request finishWithImage:output context:nil];
-
-                 }
-
-             }];
-
+
+    if (!asset) {
+        return;
+    } else if (!_playerItem.videoComposition && (filterName == nil || [filterName isEqualToString:@""])) {
+        return; // Setting up an empty filter has a cost so avoid whenever possible
     }
-
+    // TODO: filters don't work for HLS, check & return
+
+    CIFilter *filter = [CIFilter filterWithName:filterName];
+    _playerItem.videoComposition = [AVVideoComposition
+                                    videoCompositionWithAsset:asset
+                                    applyingCIFiltersWithHandler:^(AVAsynchronousCIImageFilteringRequest *_Nonnull request) {
+        if (filter == nil) {
+            [request finishWithImage:request.sourceImage context:nil];
+        } else {
+            CIImage *image = request.sourceImage.imageByClampingToExtent;
+            [filter setValue:image forKey:kCIInputImageKey];
+            CIImage *output = [filter.outputImage imageByCroppingToRect:request.sourceImage.extent];
+            [request finishWithImage:output context:nil];
+        }
+    }];
 }
 
 #pragma mark - React View Management
@@ -1463,4 +1453,4 @@ - (NSString *)cacheDirectoryPath {
     return array[0];
 }
 
-@end
+@end