-
Notifications
You must be signed in to change notification settings - Fork 187
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix docblocks for
all
to show that they are expected to receive an
array of things
- Loading branch information
Richard Quadling
authored and
Richard Quadling
committed
Oct 10, 2019
1 parent
d4207ed
commit 4fd15cd
Showing
2 changed files
with
92 additions
and
88 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
4fd15cd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rquadling can you please consider reverting this.
[]
is always an array but these methods accept anything that is\Traversable
. This change triggers errors in psalm and phpstan when passing anything that is not a plainarray
to anyall*
method.4fd15cd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rquadling rather, all of these docblocks should be
array|\Traversable