add assertion to compare arbitrary versions and to compare PHP versions. #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rquadling
reviewed
Jan 4, 2017
| } | ||
|
|
||
| /** | ||
| * Assert that extension is loaded. |
rquadling
reviewed
Jan 4, 2017
| */ | ||
| public static function version($version1, $operator, $version2, $message = null, $propertyPath = null) | ||
| { | ||
| Assertion::notEmpty($operator, 'versionCompare operator is required and cannot be empty.'); |
There was a problem hiding this comment.
Please use static:: otherwise unable to extend.
rquadling
reviewed
Jan 4, 2017
| */ | ||
| public static function phpVersion($operator, $version, $message = null, $propertyPath = null) | ||
| { | ||
| self::defined('PHP_VERSION'); |
There was a problem hiding this comment.
Please use static:: here and below.
|
depends on #204 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this request adds assertions to compare versions, and a helper for PHP version specifically. i'm working on another request to assert extension versions, but am running into HHVM issues so that helper will have to wait.
of particular interest is my opinionated requirement of the
$operatorparam. PHP'sversion_comparemethod does not require it, which changes the output/behavior of the method. i am not a fan of ambiguity so internally my new assertion asserts that$operatoris not empty. i am open to suggestions. maybe my opinion is not so great : )