Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of Assertion Chain class #318

Conversation

scyzoryck
Copy link
Contributor

Hello!

During testing performance of the package with PHPBench I've realised that Reflections methods and checking if method exists takes a lot of time. With the simple fixes we can cut execution time by around 10-15% for lazy assertions.

Benchmark can be found here: scyzoryck/php-validators-benchmark

I'm attaching blackfire profiles:

@scyzoryck
Copy link
Contributor Author

@beberlei - is there any change to take a look at this changes, please? :)

@beberlei beberlei merged commit fc352a3 into beberlei:master Dec 16, 2021
@beberlei
Copy link
Owner

@scyzoryck thank you very much! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants