Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: add support for path globbing to ignore_paths #89

Closed
wants to merge 1 commit into from

Conversation

willcl-ark
Copy link
Contributor

I'd like to use globbing as part of ignore paths, I think this does the job, so long as you don't ming adding the glob dependency.

Breaking out into functions felt easier and avoided some duplication I noticed writing it.

Copy link
Owner

@becheran becheran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not against it. I think globbing actually is a good idea for the ignore path. Though, the PR is not complete yet right? I see that you added a test in file_traversal.rs, but the existing logic of ignore_path of the mlc application was not changed?

@willcl-ark
Copy link
Contributor Author

Thanks. It was pointed out to me since, and I think I agree, that actually the more useful (and probably more typical!) use-case here would be ignoring all files ignored by git. I started implementing this in another branch:

https://github.com/willcl-ark/mlc/tree/git-aware

It's working well enough for me, but I haven't yet implemented having it search for only markup_types (if specified).

Would be curious to know what you thought of this approach vs globbing? IMO it's more robust to updates (in git repos, where I suppose this is mostly used) than glob arguments.

@willcl-ark
Copy link
Contributor Author

Closing in favour of #94

@willcl-ark willcl-ark closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants