Skip to content
This repository has been archived by the owner on Oct 30, 2023. It is now read-only.

bugfix: namespace render #34

Merged
merged 1 commit into from
Apr 14, 2021
Merged

bugfix: namespace render #34

merged 1 commit into from
Apr 14, 2021

Conversation

chifu1234
Copy link
Contributor

@chifu1234 chifu1234 commented Apr 8, 2021

Signed-off-by: kevin kk@sudo-i.net
Helm does not render Namespace to a k8s resource which has no Namespace specified. The default behavior for Helm CLI is, that the Namespace from -n is parsed into the k8s resource. The same should happen for kusible.
Does not work:

apiVersion: v1
kind: Secret
metadata:
  name: bla
  labels: 
     name: bla

does work:

apiVersion: v1
kind: Secret
metadata:
  name: bla
  labels: 
     name: bla
     namespace {{ .Release.Namespace }}

Fix:
Using own implementation of interface RESTClientGetter => inventory.Kubeconfig, thus we can add a exported function to set namespace field SetNamespace. SetNamespace then loadConfig again and sets the proper namespace in every context.
Fixing namspace in ActionConfig because same function sets namespace for action.config (later used int action.install --> Release).

Bump Helm ...

@chifu1234 chifu1234 changed the title bump helm to 3.5.3 WIP: bump helm to 3.5.3 Apr 8, 2021
@chifu1234 chifu1234 changed the title WIP: bump helm to 3.5.3 WIP: bugfix namespace render Apr 8, 2021
@chifu1234 chifu1234 changed the title WIP: bugfix namespace render bugfix namespace render Apr 9, 2021
Signed-off-by: kevin <kk@sudo-i.net>
@chifu1234 chifu1234 changed the title bugfix namespace render bugfix: namespace render Apr 12, 2021
go.mod Show resolved Hide resolved
@chifu1234 chifu1234 self-assigned this Apr 13, 2021
@chifu1234 chifu1234 added bug Something isn't working enhancement New feature or request labels Apr 13, 2021
@chifu1234 chifu1234 merged commit 6ad3507 into bedag:main Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants