Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty levsk while reading annotation config for pandas 2.0 #300

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

matchy233
Copy link
Contributor

@matchy233 matchy233 commented Jun 26, 2023

Since pandas release v2.0, None was added to the list of default NA values, making the current implementation not able to read cell hierarchy correctly from the configuration file.

This PR closes #299 by adding na_filter to read_csv in read_annotconfig to avoid not being able to identify "None" in sigconfig["Parent"].

@kohleman kohleman changed the base branch from master to dependabot/pip/devtools/flask-2.3.2 July 5, 2023 14:12
@kohleman kohleman changed the base branch from dependabot/pip/devtools/flask-2.3.2 to master July 5, 2023 14:13
@kohleman kohleman merged commit 113ee37 into bedapub:master Jul 5, 2023
1 check passed
idavydov pushed a commit to idavydov/besca that referenced this pull request Nov 9, 2023
Fix empty `levsk` while reading annotation config for pandas 2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndexError: list index out of range while running the cell annotation workbook
2 participants