Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added and removed some of the tags #123

Merged
2 commits merged into from
Jul 28, 2021
Merged

Added and removed some of the tags #123

2 commits merged into from
Jul 28, 2021

Conversation

amadejpapez
Copy link
Collaborator

I went through the list of available tags and here are some of the changes I made:

  • removed Pretty Good Privacy as it is the same as PGP
  • removed Cryptocurrency as it was only used for Bitcoin and there is already Cryptocurrency wallet tag
  • removed some of the more broad tags as they were used only on some regexes and I think there are better more specific tags
  • renamed Time to UNIX Timestamp
  • added CTF flag tag, instead of having them under Cyber Security
  • added IP tag for both IPv4 and IPv6
  • added Finance tag to Laser Card Number as it was missing

@ghost
Copy link

ghost commented Jul 28, 2021

Don't you think that tags like PGP Public key and PGP Private key do not make a lot of sense? These tags have the same names as entries, so there is not a lot of tagging involved. Remove these, maybe? The same goes for SSH RSA Public Key.

@amadejpapez
Copy link
Collaborator Author

Yeah agree. Do you see any other tags like this that could be removed?

@ghost
Copy link

ghost commented Jul 28, 2021

IPv6, IPv4, MaestroCC, Mailgun. Also rename CTF flag to CTF Flag

@ghost ghost enabled auto-merge July 28, 2021 08:29
@ghost ghost merged commit 2a560dd into main Jul 28, 2021
@ghost ghost deleted the tags branch July 28, 2021 08:29
@@ -238,7 +225,7 @@
"Tags": [
"Identifiers",
"Networking",
"IPv6"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason we used specific tags here was so people could pick and choose what they wanted specifically, if we can filter on names this isn't needed :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IPv4 and IPv6 are the ones that may actually come useful, so they can be added back yeah. Are there any others?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, it may be better to add individual tags to all entries.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants