-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added and removed some of the tags #123
Conversation
Don't you think that tags like PGP Public key and PGP Private key do not make a lot of sense? These tags have the same names as entries, so there is not a lot of tagging involved. Remove these, maybe? The same goes for SSH RSA Public Key. |
Yeah agree. Do you see any other tags like this that could be removed? |
IPv6, IPv4, MaestroCC, Mailgun. Also rename |
@@ -238,7 +225,7 @@ | |||
"Tags": [ | |||
"Identifiers", | |||
"Networking", | |||
"IPv6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason we used specific tags here was so people could pick and choose what they wanted specifically, if we can filter on names this isn't needed :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IPv4 and IPv6 are the ones that may actually come useful, so they can be added back yeah. Are there any others?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, it may be better to add individual tags to all entries.
I went through the list of available tags and here are some of the changes I made:
Pretty Good Privacy
as it is the same asPGP
Cryptocurrency
as it was only used for Bitcoin and there is alreadyCryptocurrency wallet
tagTime
toUNIX Timestamp
CTF flag
tag, instead of having them underCyber Security
IP
tag for both IPv4 and IPv6Finance
tag to Laser Card Number as it was missing