Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake8 #195

Merged
merged 17 commits into from
Oct 19, 2021
Merged

flake8 #195

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
5cbca43
ci(flake8): fix: remove select option as it disables other errors
jyooru Oct 9, 2021
781ac61
style(flake8): F841 local variable is assigned to but never used
jyooru Oct 9, 2021
0c2ebf0
style(flake8): E711 comparison to None should be 'if cond is None:'
jyooru Oct 9, 2021
8bdd160
ci(flake8): set max-line-length to 88 (black line length)
jyooru Oct 9, 2021
b229549
Update tests/test_identifier.py
jyooru Oct 10, 2021
e59de34
Merge branch 'main' into flake8
jyooru Oct 10, 2021
dae6d2f
style(flake8): E731 do not assign a lambda expression, use a def
jyooru Oct 16, 2021
1b8a17f
ci(flake8): ignore line too long errors
jyooru Oct 16, 2021
3bac7dc
style(flake8): F401 'pywhat.filter.Distribution' imported but unused
jyooru Oct 16, 2021
ba6f6d3
style(flake8): ignore W503 line break before binary operator
jyooru Oct 16, 2021
f9a096d
Merge branch 'main' into flake8
jyooru Oct 16, 2021
94050b1
style(flake8): F401 imported but unused
jyooru Oct 16, 2021
f7f6de6
style(flake8): W605 invalid escape sequence
jyooru Oct 16, 2021
8a5540c
style(flake8): E722 do not use bare 'except'
jyooru Oct 18, 2021
6613aaf
test: add test to test exception
jyooru Oct 18, 2021
2f4e0cc
Merge branch 'main' into flake8
jyooru Oct 18, 2021
4342bdc
refactor: remove unnecessary try except
jyooru Oct 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .flake8
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[flake8]
max-line-length = 88
3 changes: 1 addition & 2 deletions .github/workflows/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,8 @@ jobs:
python-version: ${{ matrix.python-version }}
architecture: x64
- run: python -m pip install flake8 nox poetry
- run: flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
- run: flake8 . --count --show-source --statistics
- run: python -m nox
env:
OS: ${{ matrix.os }}
PYTHON: ${{ matrix.python-version }}

2 changes: 1 addition & 1 deletion tests/test_filtration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def test_distribution6():

def test_distribution7():
with pytest.raises(InvalidTag):
dist = Distribution({"Tags": "Media", "MinRarity": 0.7})
Distribution({"Tags": "Media", "MinRarity": 0.7})


def test_filter():
Expand Down
2 changes: 1 addition & 1 deletion tests/test_identifier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def test_identifier_sorting6():

def test_only_text():
out = r.identify("fixtures/file")
assert None == out["Regexes"]
assert None is out["Regexes"]
jyooru marked this conversation as resolved.
Show resolved Hide resolved

out = r.identify("THM{7281j}}", only_text=True)
assert "TryHackMe Flag Format" in out["Regexes"]["text"][0]["Regex Pattern"]["Name"]
Expand Down