Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set some regex to 0 #198

Merged
merged 1 commit into from
Oct 10, 2021
Merged

Set some regex to 0 #198

merged 1 commit into from
Oct 10, 2021

Conversation

bee-san
Copy link
Owner

@bee-san bee-san commented Oct 9, 2021

Too spammy, I set them to 0.1 earlier but I was meant to set to 0!

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2021

Codecov Report

Merging #198 (8b2a4e7) into main (e36b83a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
+ Coverage   92.14%   92.16%   +0.01%     
==========================================
  Files          13       13              
  Lines        1617     1620       +3     
==========================================
+ Hits         1490     1493       +3     
  Misses        127      127              
Impacted Files Coverage Δ
pywhat/__init__.py 90.90% <100.00%> (ø)
tests/test_click.py 98.15% <100.00%> (ø)
tests/test_regex_identifier.py 98.54% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e36b83a...8b2a4e7. Read the comment docs.

@ghost ghost enabled auto-merge October 9, 2021 17:38
ghost
ghost previously approved these changes Oct 9, 2021
@ghost ghost disabled auto-merge October 9, 2021 17:44
@ghost ghost dismissed their stale review October 9, 2021 17:50

Tests fail

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change rarity of distributions used in tests

Too spammy, I set them to 0.1 earlier but I was meant to set to 0!
@bee-san bee-san merged commit 0765321 into main Oct 10, 2021
@bee-san bee-san deleted the bee-set-to-0 branch October 10, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants