-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mount commands and fstab entries with clear credentials #210
Conversation
pywhat/Data/regex.json
Outdated
@@ -1026,6 +1026,30 @@ | |||
"Bug Bounty" | |||
] | |||
}, | |||
{ | |||
"Name": "Mount Command With Clear Credentials", | |||
"Regex": "^(mount(.cifs)?[ ]+[^\\n]*(username=[^, \\n]+[^\\n ]*password=[^, \\n]+|password=[^, \\n]+[^\\n ]*username=[^, \\n]+))$", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What[ ]+
is supposed to mean? Why not \s+
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ ]+
indeed does have the same meaning as \s+
, I'll change it if it's more meaningful.
Code seems to break with the change, let me check out why. |
FIxed 😉 |
Codecov Report
@@ Coverage Diff @@
## main #210 +/- ##
==========================================
+ Coverage 94.46% 94.50% +0.03%
==========================================
Files 14 14
Lines 1717 1729 +12
==========================================
+ Hits 1622 1634 +12
Misses 95 95
Continue to review full report at Codecov.
|
Windows tests failure are currently investigated by GitHub > https://www.githubstatus.com/ |
Tests should now be able to run normally by the way 😉 |
Prerequisites
Why do we need this pull request?
mount
andmount.cifs
commands with clear credentials as args. Can be found in various scripts. Complex commands with multiple arguments, flags and random arg order are supported.fstab
entries. Easily found vulnerability.Copy / paste of output