-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding AWS credential types #91
Conversation
Adding AWS Access Key and AWS Secret Access Key to the supported regex patterns
Thank you for this! This needs tests, feel free to add them or we can do it later :) |
My bad. I've added the tests for you. |
Merge conflicts😢 |
If possible, please fix the merge conflicts && remove the descriptions -- we try to only include them if it's needed (I.E. the name is not descriptive of what it is) |
Seems like some newly added API key formats are first getting matched as AWS ones. You can change tests to this format: |
I have fixed tests and removed |
Adding AWS Access Key and AWS Secret Access Key to the supported regex patterns