Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding AWS credential types #91

Merged
merged 7 commits into from
Jul 8, 2021
Merged

Adding AWS credential types #91

merged 7 commits into from
Jul 8, 2021

Conversation

belialboy
Copy link
Contributor

Adding AWS Access Key and AWS Secret Access Key to the supported regex patterns

Adding AWS Access Key and AWS Secret Access Key to the supported regex patterns
@bee-san bee-san added the Needs Tests PR does not contain tests label Jun 19, 2021
@bee-san
Copy link
Owner

bee-san commented Jun 19, 2021

Thank you for this! This needs tests, feel free to add them or we can do it later :)

@belialboy
Copy link
Contributor Author

My bad. I've added the tests for you.

@bee-san bee-san removed the Needs Tests PR does not contain tests label Jun 20, 2021
@ghost
Copy link

ghost commented Jun 26, 2021

Merge conflicts😢

@bee-san
Copy link
Owner

bee-san commented Jun 26, 2021

If possible, please fix the merge conflicts && remove the descriptions -- we try to only include them if it's needed (I.E. the name is not descriptive of what it is)

@amadejpapez
Copy link
Collaborator

Seems like some newly added API key formats are first getting matched as AWS ones. You can change tests to this format:
assert "Amazon Web Services Access Key" in res as currently test is checking only the first match.

@amadejpapez
Copy link
Collaborator

I have fixed tests and removed AWS Access Key ID as I think it is the same as newly added Amazon Web Services Access Key.

@amadejpapez amadejpapez requested a review from bee-san July 4, 2021 18:14
@bee-san bee-san merged commit 97b1d56 into bee-san:main Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants