Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OID-style key/value data for BrowserDetails network details #1861

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Use OID-style key/value data for BrowserDetails network details #1861

merged 1 commit into from
Jan 20, 2020

Conversation

bcoles
Copy link
Collaborator

@bcoles bcoles commented Jan 18, 2020

Had this diff lying around for a while. I think these are the last of the BrowserDetails which aren't OID style.

The host IP address seems more suited to the network object than the host object, as we the IP address more than likely represents an intermediary router IP address.

@jcrew99
Copy link
Collaborator

jcrew99 commented Jan 20, 2020

This makes sense and seems fine to be merged :)

@jcrew99 jcrew99 merged commit 23dc5c7 into master Jan 20, 2020
@bcoles bcoles deleted the bcoles-patch-2 branch January 20, 2020 05:37
@wheatley wheatley mentioned this pull request Aug 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcrew99 jcrew99 jcrew99 approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcoles @jcrew99