[fix] Dynamic reconfiguration policies #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikepapadim
reviewed
Feb 7, 2024
| if (policy == Policy.PERFORMANCE) { | ||
| for (int k = 0; k < PERFORMANCE_WARMUP; k++) { | ||
| for (int k = 0; k < 100; k++) { |
mikepapadim
reviewed
Feb 7, 2024
| if (policy == Policy.PERFORMANCE) { | ||
| for (int k = 0; k < PERFORMANCE_WARMUP; k++) { | ||
| for (int k = 0; k < 100; k++) { |
mikepapadim
requested changes
Feb 7, 2024
mairooni
requested changes
Feb 7, 2024
| @@ -805,7 +805,9 @@ private void updateProfiler() { | |||
| private void dumpDeoptReason(TornadoBailoutRuntimeException e) { | |||
| if (!Tornado.DEBUG) { | |||
| System.err.println(STR."\{RED}[Bailout] Running the sequential implementation. Enable --debug to see the reason.\{RESET}"); | |||
| } else { | |||
| }else | |||
|
|
|||
|
all changes done. |
mairooni
approved these changes
Feb 7, 2024
jjfumero
added a commit
that referenced
this pull request
Feb 29, 2024
Improvements ~~~~~~~~~~~~~~~~~~ - `#323 <https://github.com/beehive-lab/TornadoVM/pull/323>`_: Set Accelerator Memory Limit per Execution Plan at the API level - `#328 <https://github.com/beehive-lab/TornadoVM/pull/328>`_: Javadoc API to run with concurrent devices and memory limits - `#340 <https://github.com/beehive-lab/TornadoVM/pull/340>`_: New API calls to enable ``threadInfo`` and ``printKernel`` from the Execution Plan API. - `#334 <https://github.com/beehive-lab/TornadoVM/pull/334>`_: Dynamically enable/disable profiler after first run Compatibility ~~~~~~~~~~~~~~~~~~ - `#337 <https://github.com/beehive-lab/TornadoVM/pull/337>`_ : Initial support for Graal and JDK 21.0.2 Bug Fixes ~~~~~~~~~~~~~~~~~~ - `#322 <https://github.com/beehive-lab/TornadoVM/pull/322>`_: Fix duplicate thread-info debug message when the debug option is also enabled. - `#325 <https://github.com/beehive-lab/TornadoVM/pull/325>`_: Set/Get accesses for the ``MatrixVectorFloat4`` type fixed - `#326 <https://github.com/beehive-lab/TornadoVM/pull/326>`_: Fix installation script for running with Python >= 3.12 - `#327 <https://github.com/beehive-lab/TornadoVM/pull/327>`_: Fix Memory Limits for all supported Panama off-heap types. - `#329 <https://github.com/beehive-lab/TornadoVM/pull/329>`_: Fix timers for the dynamic reconfiguration policies - `#330 <https://github.com/beehive-lab/TornadoVM/pull/330>`_: Fix the profiler logs when silent mode is enabled - `#332 <https://github.com/beehive-lab/TornadoVM/pull/332>`_: Fix Batch processing when having multiple task-graphs in a single execution plan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the dynamic reconfiguration to select the correct device depending on the input policies.
Problem description
The issue was that the timers were not correctly calculated, and it includes the whole performance evaluation in the case of the performance policy. This PR solves this issue and it refactors the sequential and parallel strategies.
Backend/s tested
This PR has been tested with the OpenCL backend
OS tested
Mark the OS where this PR is tested.
Did you check on FPGAs?
If it is applicable, check your changes on FPGAs.
How to test the new patch?