Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove writeFile for Julia in unit-test #438

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

jjfumero
Copy link
Member

Description

To avoid permission problems in our Jenkins servers, this PR deletes the write output to a file for one of the unit-tests.
The unit-test itself checks the output.

Problem description

The issue is in the permissions of our Jenkins server, only to allow write permissions for one of the tests in the whole test suite. To avoid this, the test in particular can completely avoid writing to disk. In fact, the test already checks all results in memory, thus, there is no need to write the file.

Backend/s tested

Mark the backends affected by this PR.

  • OpenCL
  • PTX
  • SPIRV

OS tested

Mark the OS where this PR is tested.

  • Linux
  • OSx
  • Windows

Did you check on FPGAs?

If it is applicable, check your changes on FPGAs.

  • Yes
  • No

How to test the new patch?

make
tornado-test -V --fast uk.ac.manchester.tornado.unittests.compute.ComputeTests

@jjfumero jjfumero added tests fix Provides a fix labels May 31, 2024
@jjfumero jjfumero requested review from mikepapadim and stratika May 31, 2024 10:33
@jjfumero jjfumero self-assigned this May 31, 2024
@stratika stratika closed this May 31, 2024
@stratika stratika reopened this May 31, 2024
@jjfumero jjfumero merged commit 31d5974 into beehive-lab:develop Jun 3, 2024
2 checks passed
@jjfumero jjfumero deleted the fix/test/compute branch June 3, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Provides a fix tests
Projects
Development

Successfully merging this pull request may close these issues.

3 participants