Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPU Virtual tests removed, since the scheduler between CPU/GPU is the same #463

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

jjfumero
Copy link
Member

@jjfumero jjfumero commented Jun 26, 2024

Description

The CPU Virtual Tests were failing due to the thread -scheduler changes. Since the CPU scheduler now uses the Generic GPU scheduler, there is no distinction between them in regards with the Virtual Tests. This PR fixes this.

Problem description

Virtual Tests for CPU giving wrong results because the scheduler used is the Generic GPU scheduler.

Backend/s tested

Mark the backends affected by this PR.

  • OpenCL
  • PTX
  • SPIRV

OS tested

Mark the OS where this PR is tested.

  • Linux
  • OSx
  • Windows

Did you check on FPGAs?

If it is applicable, check your changes on FPGAs.

  • Yes
  • No

How to test the new patch?

tornado -ea  --jvm "-Xmx6g -Dtornado.recover.bailout=False -Dtornado.unittests.verbose=True  -Dtornado.device.desc=${TORNADO_SDK}/examples/virtual-device-GPU.json -Dtornado.print.kernel=True -Dtornado.virtual.device=True -Dtornado.print.kernel.dir=${TORNADO_SDK}/virtualKernelOut.out"  -m  tornado.unittests/uk.ac.manchester.tornado.unittests.tools.TornadoTestRunner  --params "uk.ac.manchester.tornado.unittests.virtual.TestVirtualDeviceKernel#testVirtualDeviceKernel"
tornado -ea  --jvm "-Xmx6g -Dtornado.recover.bailout=False -Dtornado.unittests.verbose=True  -Dtornado.device.desc=${TORNADO_SDK}/examples/virtual-device-GPU.json -Dtornado.virtual.device=True -Dtornado.feature.extraction=True -Dtornado.features.dump.dir=${TORNADO_SDK}/virtualFeaturesOut.out"  -m  tornado.unittests/uk.ac.manchester.tornado.unittests.tools.TornadoTestRunner  --params "uk.ac.manchester.tornado.unittests.virtual.TestVirtualDeviceFeatureExtraction#testVirtualDeviceFeatures"

@jjfumero jjfumero added tests fix Provides a fix labels Jun 26, 2024
@jjfumero jjfumero requested review from mairooni and stratika June 26, 2024 09:36
@jjfumero jjfumero self-assigned this Jun 26, 2024
Copy link
Collaborator

@mairooni mairooni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@stratika stratika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested on Linux and macOS

@jjfumero jjfumero merged commit 469765f into beehive-lab:develop Jun 26, 2024
2 checks passed
@jjfumero jjfumero deleted the fix/virtual/tests branch June 26, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Provides a fix tests
Projects
Development

Successfully merging this pull request may close these issues.

3 participants