Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration test #31

Merged
merged 14 commits into from
Apr 29, 2024
Merged

Fix integration test #31

merged 14 commits into from
Apr 29, 2024

Conversation

Veldhoen
Copy link
Member

Fixed bug in S3 upload of archive

@Veldhoen Veldhoen requested a review from greenw0lf April 16, 2024 13:53
@Veldhoen Veldhoen marked this pull request as ready for review April 16, 2024 13:53
@Veldhoen
Copy link
Member Author

@jblom unrelated to this specific PR, but it seems like the gh action uses a different Flake8 which complains about syntax within strings. Any clue as to how to solve this?? It doesn't happen locally, although I think the same Flake8 should be installed from the pyproject.toml

@Veldhoen
Copy link
Member Author

Test also fails in GH actions because it can't write to ./data

Copy link
Collaborator

@greenw0lf greenw0lf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It runs successfully indeed! I would suggest though to also have a look at the PR I just opened for the audio extraction worker: beeldengeluid/audio-extraction-worker#16

I did some things differently, including the changes you made. Maybe it is more suitable to do it my way rather than this way? With your method, I would still have the test fail because of the file/folder names being mismatched.

io_util.py Outdated Show resolved Hide resolved
io_util.py Show resolved Hide resolved
@Veldhoen
Copy link
Member Author

Test also fails in GH actions because it can't write to ./data

Fixed this by using specific config-test.yml

@Veldhoen Veldhoen merged commit bee53d1 into main Apr 29, 2024
1 check passed
@Veldhoen Veldhoen deleted the fix-integration-test branch April 29, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants