-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix integration test #31
Conversation
@jblom unrelated to this specific PR, but it seems like the gh action uses a different Flake8 which complains about syntax within strings. Any clue as to how to solve this?? It doesn't happen locally, although I think the same Flake8 should be installed from the pyproject.toml |
Test also fails in GH actions because it can't write to ./data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It runs successfully indeed! I would suggest though to also have a look at the PR I just opened for the audio extraction worker: beeldengeluid/audio-extraction-worker#16
I did some things differently, including the changes you made. Maybe it is more suitable to do it my way rather than this way? With your method, I would still have the test fail because of the file/folder names being mismatched.
Have untar module return complete path Co-authored-by: Dragoș Bălan <33976463+greenw0lf@users.noreply.github.com>
Co-authored-by: Dragoș Bălan <33976463+greenw0lf@users.noreply.github.com>
Fixed this by using specific config-test.yml |
Fixed bug in S3 upload of archive