Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete Dockerfile-noGPU #47

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Delete Dockerfile-noGPU #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8547b35
Delete Dockerfile-noGPU
gb-beng Jul 25, 2024
16f3867
Update README
gb-beng Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 0 additions & 38 deletions Dockerfile-noGPU
View file
Open in desktop

This file was deleted.

6 changes: 2 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,11 @@ Apply VisXP models trained for feature extraction from keyframes and audio spect

From the root of the repo, run
```
DOCKER_BUILDKIT=1 docker build -t dane-visual-feature-extraction-worker .
docker build -t dane-visual-feature-extraction-worker .
```
Buildkit is optional, it may speed up building (see https://docs.docker.com/build/buildkit/)
NB: building the image has occasionally led to mysterious connection errors, which we haven't been able to track down and solve (yet). Discarding the poetry.lock has been a way to circumvent these.

The default Dockerfile is based on an image that allows GPU processing. A Dockerfile based on a regular Python base image is provided in `Dockerfile-noGPU`, but should not be essential.
Whether the processing actually uses GPU depends on the availability of GPU in the container.
The Dockerfile support both CPU and GPU processing. Whether the processing actually uses GPU depends on the availability of GPU in the container.

### Config

Expand Down