Improve color contrast on hidden codes

beemdevelopment · Jan 22, 2025 · 3d50ab1 · 3d50ab1
1 parent 9ab949a
commit 3d50ab1
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/app/src/main/java/com/beemdevelopment/aegis/ui/views/EntryHolder.java b/app/src/main/java/com/beemdevelopment/aegis/ui/views/EntryHolder.java
@@ -369,9 +369,11 @@ public void revealCode() {
     public void hideCode() {
         String code = getOtp();
         String hiddenText = code.replaceAll("\\S", Character.toString(HIDDEN_CHAR));
+        stopExpirationAnimation();
+
         updateTextViewWithDots(_profileCode,  hiddenText, code);
         updateTextViewWithDots(_nextProfileCode,  hiddenText, code);
-        stopExpirationAnimation();
+
         _hidden = true;
     }
 
@@ -384,6 +386,7 @@ private void updateTextViewWithDots(TextView textView, String hiddenCode, String
         float dotsWidth = paint.measureText(hiddenCode);
         float scaleFactor = codeWidth / dotsWidth;
         scaleFactor = (float)(Math.round(scaleFactor * 10.0) / 10.0);
+        textView.setTextColor(MaterialColors.getColor(textView, R.attr.colorCodeHidden));
 
         // If scale is higher or equal to 0.8, do nothing and proceed with the normal text rendering
         if (scaleFactor >= 0.8) {

diff --git a/app/src/main/res/values/attrs.xml b/app/src/main/res/values/attrs.xml
@@ -8,6 +8,7 @@
     <attr name="colorSuccess" />
     <attr name="colorOnSurfaceDim" />
     <attr name="colorCode" />
+    <attr name="colorCodeHidden" />
 
     <declare-styleable name="SlideIndicator">
         <attr name="dot_radius" format="dimension" />

diff --git a/app/src/main/res/values/themes.xml b/app/src/main/res/values/themes.xml
@@ -62,6 +62,7 @@
         <item name="colorSuccess">@color/aegis_theme_light_success</item>
         <item name="colorOnSurfaceDim">@color/aegis_theme_light_onSurfaceDim</item>
         <item name="colorCode">?attr/colorPrimary</item>
+        <item name="colorCodeHidden">?attr/colorOutlineVariant</item>
         <!-- Intro colors -->
         <item name="dot_color">?attr/colorSurfaceVariant</item>
         <item name="dot_color_selected">?attr/colorOnSurfaceVariant</item>
@@ -132,6 +133,7 @@
         <item name="colorSuccess">@color/aegis_theme_dark_success</item>
         <item name="colorOnSurfaceDim">@color/aegis_theme_dark_onSurfaceDim</item>
         <item name="colorCode">?attr/colorPrimary</item>
+        <item name="colorCodeHidden">?attr/colorOutlineVariant</item>
         <!-- Intro colors -->
         <item name="dot_color">?attr/colorSurfaceVariant</item>
         <item name="dot_color_selected">?attr/colorOnSurfaceVariant</item>
@@ -159,6 +161,7 @@
         <item name="colorSurfaceDim">#000000</item>
         <item name="colorSurfaceBright">#000000</item>
         <item name="colorCode">@android:color/white</item>
+        <item name="colorCodeHidden">#2F2F2F</item>
         <item name="colorProgressbar">@android:color/white</item>
     </style>
 
@@ -179,6 +182,7 @@
         <item name="colorSurfaceDim">#000000</item>
         <item name="colorSurfaceBright">#000000</item>
         <item name="colorCode">@android:color/white</item>
+        <item name="colorCodeHidden">#2F2F2F</item>
         <item name="colorProgressbar">@android:color/white</item>
     </style>