Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update references to FreeOTP and add version hint "1.x" #1204

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

ranjeetchouhan
Copy link

@ranjeetchouhan ranjeetchouhan commented Oct 2, 2023

Fixes #1196.

Copy link
Member

@alexbakker alexbakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but please only update the source (i.e. English) strings. It's easy to make mistakes when making changes to translations for languages you don't speak, especially RTL languages.

Co-authored-by: Alexander Bakker <ab@alexbakker.me>
Copy link
Member

@alexbakker alexbakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexbakker alexbakker merged commit 4d729d1 into beemdevelopment:master Dec 27, 2023
3 checks passed
juleskers added a commit to juleskers/Aegis that referenced this pull request Jul 2, 2024
Include the '(1.x)' qualifier directly in the import-source selection dropdown to avoid raising false expectations.

See also:
- beemdevelopment#1204, where the 1.x-hint was introduced
- beemdevelopment#1084: tracking issue for 2.x support
- freeotp/freeotp-android#381
  FreeOTP-issue to reconsider the brittle serialised java format used by 2.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update references to FreeOTP and add version hint "1.x"
2 participants