Add ability to hide account name in tiles mode #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbakker
requested changes
Aug 9, 2024
app/src/main/java/com/beemdevelopment/aegis/ui/views/EntryHolder.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/ui/views/EntryHolder.java
Outdated
Show resolved
Hide resolved
michaelschattgen
force-pushed
the
feature/hide-account-name-tiles
branch
from
f98096c
to
71c0ad2
Compare
alexbakker
approved these changes
Aug 12, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the limitation to refrain the user from setting the account name to hidden whenever the Tiles mode is being used. We still override the account name position preference it's set to "Next to issuer" since that will make a mess in Tiles mode.
We would have to think about a nice way to handle all the different customization options between the different viewmodes though.
Fixes #1285