Account for audit log entries that reference deleted entries #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelschattgen
requested changes
Aug 27, 2024
There was a problem hiding this comment.
I think the check itself is fine but what do you think of keeping the "An entry was shared" but replacing the entry name below that with something like "Deleted" (or "this entry has been deleted")?
This way we don't have to create a new string for each of the different events whenever it's about a deleted entry.
alexbakker
force-pushed
the
fix-audit-log-crash
branch
from
056b03e
to
f6d4d66
Compare
|
Agreed, that's much better. Fixed! |
michaelschattgen
requested changes
Aug 27, 2024
...ain/java/com/beemdevelopment/aegis/ui/fragments/preferences/AuditLogPreferencesFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/ui/views/AuditLogHolder.java
Show resolved
Hide resolved
This fixes the following crash I noticed in the developer console: ``` Exception java.lang.AssertionError: at com.beemdevelopment.aegis.util.UUIDMap.getByUUID (UUIDMap.java:127) at com.beemdevelopment.aegis.vault.VaultRepository.getEntryByUUID (VaultRepository.java:229) at com.beemdevelopment.aegis.ui.fragments.preferences.AuditLogPreferencesFragment.lambda$onViewCreated$0 (AuditLogPreferencesFragment.java:70) at androidx.lifecycle.LiveData.considerNotify (LiveData.java:133) at androidx.lifecycle.LiveData.dispatchingValue (LiveData.java:151) at androidx.lifecycle.LiveData.setValue (LiveData.java:309) at androidx.lifecycle.LiveData$1.run (LiveData.java:93) at android.os.Handler.handleCallback (Handler.java:959) at android.os.Handler.dispatchMessage (Handler.java:100) at android.os.Looper.loopOnce (Looper.java:232) at android.os.Looper.loop (Looper.java:317) at android.app.ActivityThread.main (ActivityThread.java:8592) at java.lang.reflect.Method.invoke at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:580) at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:878) ```
alexbakker
force-pushed
the
fix-audit-log-crash
branch
from
f6d4d66
to
b92956d
Compare
michaelschattgen
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following crash I noticed in the developer console: