Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search feature for better UX #1545

Conversation

michaelschattgen
Copy link
Member

@michaelschattgen michaelschattgen commented Nov 24, 2024

This PR improves the search feature as requested in #1527 and #1536. After this gets merged Aegis will:

  1. Hide the group chips when user starts searching
  2. Ignore the current active group filter
  3. Matches now in all fields that are enabled to search in

Example:

Search Filter Issuer Name Match?
GitHub michaelschattgen GitHub michaelschattgen ✅ Yes
GitHub GitHub michaelschattgen ✅ Yes
michaelschattgen GitHub michaelschattgen ✅ Yes
hub michaelschattgen GitHub michaelschattgen ✅ Yes
michaelschattgen Git GitHub michaelschattgen ✅ Yes
Github e GitHub michaelschattgen ✅ Yes
GitHub michaelschattgen 1 GitHub michaelschattgen ❌ No
hub z GitHub michaelschattgen ❌ No

Closes #1527, closes #1536

@ghost ghost mentioned this pull request Nov 25, 2024
Copy link
Member

@alexbakker alexbakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. One minor issue: The chip group does not become visible again if the search is cancelled with the X button.

@alexbakker alexbakker merged commit 5213baf into beemdevelopment:master Nov 25, 2024
4 checks passed
@ivancarlosti
Copy link

Updated app, looks like partial words search is not working :/

@michaelschattgen
Copy link
Member Author

We've merged this 10 minutes ago. The feature will be available in our next release.

@ghost
Copy link

ghost commented Dec 3, 2024

@michaelschattgen Hi there,
I just wondering this its bug or somthing, that the Group filter still visible when keybaord Pop-up

See here the defreen between the public, and the "dev" version , when the app its open
The new release: 3.3.2 - here the Group its visible
Screenshot_20241203_002301

" agisbev : 3.3.1-d48f2ea (master) - and here its no't.
Screenshot_20241203_002404

Thanks again for your'e time!

@michaelschattgen
Copy link
Member Author

Are you completely sure you're actually running 3.3.2? Could you please double check this? Either through Aegis' about page or your device settings.

I just updated to 3.3.2 through the Google Play Store and it hides the group filter upon opening search for me (which is the intended behaviour).

@ghost
Copy link

ghost commented Dec 3, 2024

Yes, i download the new version from google play store about 2h new
Screenshot_20241203_004741
Just to be sure , i am no't messing somthing , when you open the the app the "Groube filter still visible " but when you close the search, let say go to `setting and open the search again, new its work

Like this
Screenshot_20241203_005446

@michaelschattgen
Copy link
Member Author

Ah sorry, i see it now. I assume you have 'Focus search on start' enabled, this causes the group filter to not properly hide due to a race condition. Will fix it sometime later this week, thanks for letting us know!

@ghost
Copy link

ghost commented Dec 3, 2024

@michaelschattgen Hi
i have new thing that can help you, " the isuss its becaus the Vault encryption
(boiomatrics/password etc.
When you set the app lock to "non" its work, I hope this help.

• Before :

Vault.encryption.On.mp4

• After :

Vault.encryption.Of.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search with filter enabled Partial words search feature
3 participants