-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve search feature for better UX #1545
Improve search feature for better UX #1545
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat. One minor issue: The chip group does not become visible again if the search is cancelled with the X button.
0f06105
to
503ce87
Compare
Updated app, looks like partial words search is not working :/ |
We've merged this 10 minutes ago. The feature will be available in our next release. |
@michaelschattgen Hi there, See here the defreen between the public, and the "dev" version , when the app its open " agisbev : 3.3.1-d48f2ea (master) - and here its no't. Thanks again for your'e time! |
Are you completely sure you're actually running 3.3.2? Could you please double check this? Either through Aegis' about page or your device settings. I just updated to 3.3.2 through the Google Play Store and it hides the group filter upon opening search for me (which is the intended behaviour). |
Ah sorry, i see it now. I assume you have 'Focus search on start' enabled, this causes the group filter to not properly hide due to a race condition. Will fix it sometime later this week, thanks for letting us know! |
@michaelschattgen Hi • Before : Vault.encryption.On.mp4• After : Vault.encryption.Of.mp4 |
This PR improves the search feature as requested in #1527 and #1536. After this gets merged Aegis will:
Example:
GitHub michaelschattgen
GitHub
michaelschattgen
hub michaelschattgen
michaelschattgen Git
Github e
GitHub michaelschattgen 1
hub z
Closes #1527, closes #1536