Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Today widget still populated and allows submitting data even after logout in the app #236

Closed
krugerk opened this issue Dec 2, 2020 · 2 comments
Closed

Today widget still populated and allows submitting data even after logout in the app #236

krugerk opened this issue Dec 2, 2020 · 2 comments
Labels
BUG Opposite of feature UVI Will count as a User-Visible Improvement zap (closed as) Fixed / completed

Comments

@krugerk
Copy link
Contributor

krugerk commented Dec 2, 2020 •
edited by dreeves
Loading

Replicata

  1. Be on BeemiOS version 5.8 (iOS 14.2)
  2. Log in via the app
  3. Have some goals, view the main screen (gallery / list of goals)
  4. Leave the app, configure Today Widget
  5. Note that the widget shows up to three goals
  6. Return to the app
  7. Settings / sign out
  8. Note the app now asks for login data
  9. Leave the app, return to the screen with the Today Widget
  10. Notice the widget still shows the goals of before
  11. And allows submitting data (in case at least one of those goals allows manual data entry)

Expectata

  • no goals listed in today widget after signing out
  • instead of a blank widget, widget should show a message
  • that one is not signed in, no goals configured ...
  • return to the app, load goals there, ...

Resultata

List of goals remained available in the widget.
Widget allowed sending data to those goals.

Cognata
@krugerk krugerk added the BUG Opposite of feature label Dec 2, 2020
@adamwolf
Copy link

adamwolf commented Dec 2, 2020

we actually have the same problem in beedroid! :)

@krugerk
Copy link
Contributor Author

krugerk commented Dec 2, 2020

See, the apps have more in common than some of these tickets may indicate. 😛

The today widget grabs data from storage

BeeSwift/BeeSwiftToday/TodayViewController.swift

Line 46 in e470053

@objc func updateDataSource() {

which is populated app side

BeeSwift/BeeSwift/CurrentUserManager.swift

Line 179 in e470053

func updateTodayWidget() {

As is, signing out does not clear the goal data stored there:

BeeSwift/BeeSwift/CurrentUserManager.swift

Line 146 in e470053

func signOut() {

@krugerk krugerk mentioned this issue Dec 3, 2020
Closed
@theospears theospears mentioned this issue Jul 31, 2023
Merged
@dreeves dreeves added UVI Will count as a User-Visible Improvement zap (closed as) Fixed / completed labels Sep 4, 2023
@krugerk krugerk mentioned this issue Nov 8, 2024
Merged
theospears pushed a commit that referenced this issue Nov 15, 2024
@krugerk
removes the deprecated and unmaintained Today View extension (#500)
1912a52 
Today View extensions have been deprecated since iOS 14. Furthermore
they are [no longer available at all on iOS
18](https://developer.apple.com/documentation/ios-ipados-release-notes/ios-ipados-18-release-notes#Widgets).

This app's such extension allowed for viewing up to three goals and
provided quick data entry for them.
It seems each iteration of iOS since 14 has tucked the Today View
extensions further and further out of reach.
A more powerful replacement could be iOS 14 style widgets (#68).

Today View extension tickets: #97, #98, #114, #236

This merge request merely removes the legacy code/feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BUG Opposite of feature UVI Will count as a User-Visible Improvement zap (closed as) Fixed / completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the storage used for the today widget upon signout
3 participants
@dreeves @adamwolf @krugerk