Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Icon missing padding #25

Closed
dsernst opened this issue Jan 14, 2020 · 3 comments · Fixed by #139
Closed

App Icon missing padding #25

dsernst opened this issue Jan 14, 2020 · 3 comments · Fixed by #139
Assignees
@krugerk
Labels
PEA Easy-peasy UVI Will count as a User-Visible Improvement
Milestone
5.7

Comments

@dsernst
Copy link

dsernst commented Jan 14, 2020

The app icon could really use some white padding around the sides.

Here's an example of what it looks like next to other common apps:

Just like 20% padding around the sides would make it look a lot cleaner.
@mauricioralcala
Copy link

I agree. Padding would make it look more uniform with the rest of the OS.

@krugerk krugerk added PEA Easy-peasy UVI Will count as a User-Visible Improvement labels Jul 2, 2020
andrewpbrett added a commit that referenced this issue Aug 16, 2020
@andrewpbrett
Merge pull request #139 from krugerk/bugfix/25-app-icon-missing-padding
2ed7222 
[#25] more padding around the infinibee
@krugerk krugerk linked a pull request Aug 16, 2020 that will close this issue
[#25] more padding around the infinibee #139
Merged
@krugerk krugerk added this to the 5.7 milestone Aug 16, 2020
@krugerk krugerk self-assigned this Aug 16, 2020
@krugerk krugerk closed this as completed Aug 16, 2020
@andrewpbrett andrewpbrett reopened this Aug 31, 2020
@andrewpbrett
Copy link
Contributor

@krugerk the icon now has a thin black border around the edge, I don't think I've seen it before so I'm assuming this was introduced with the new icon sets here? https://apps.apple.com/us/app/beeminder/id551869729

@krugerk krugerk mentioned this issue Sep 2, 2020
Closed
@krugerk
Copy link
Contributor

krugerk commented Sep 2, 2020

closing this one - app icon with more padding - and handling the black lines in a separate ticket (#179) (should allow for better issue tracking)

@krugerk krugerk closed this as completed Sep 2, 2020
@krugerk krugerk mentioned this issue Sep 2, 2020
Merged
andrewpbrett pushed a commit that referenced this issue Sep 3, 2020
@krugerk @andrewpbrett
Remove the black border around the app icons
a41c52c 
recreated the app icon with padding (#25) but without the black border introduced in #139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krugerk krugerk

Labels
PEA Easy-peasy UVI Will count as a User-Visible Improvement
Projects
None yet
Milestone
5.7
Development

Successfully merging a pull request may close this issue.

[#25] more padding around the infinibee
4 participants
@andrewpbrett @krugerk @dsernst @mauricioralcala