Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Today Widget seems to prefer compact (rarely if ever shows expanded) #92

Closed
krugerk opened this issue Jul 14, 2020 · 0 comments · Fixed by #93
Closed

Today Widget seems to prefer compact (rarely if ever shows expanded) #92

krugerk opened this issue Jul 14, 2020 · 0 comments · Fixed by #93
Assignees
@krugerk
Labels
BUG Opposite of feature PEA Easy-peasy STY Style / polish / CSS / pigsty / eyesore UVI Will count as a User-Visible Improvement

Comments

@krugerk
Copy link
Contributor

krugerk commented Jul 14, 2020

steps to reproduce

  1. have more than one goal
  2. install the today widget
  3. note that the beeminder today widget is shown in compact mode (just one goal) and does not offer the option to expand (for up to three goals)

Expected

given an account with more than one goal, the today widget should offer an expanded view allowing for displaying up to three goals at a time

Actual

today widget displayed only one goal with no option to expand it to display more

notes

Looking over the code, it seems a quick fix might be as easy as moving setting widgetLargestAvailableDisplayMode to after having obtained the goalDictionaries (via updateDataSource)

hardware / software

recent master branch (Commit d7c6872)
Simulator, iOS 13.5 / iPhone 11 Pro
@krugerk krugerk added BUG Opposite of feature PEA Easy-peasy UVI Will count as a User-Visible Improvement STY Style / polish / CSS / pigsty / eyesore labels Jul 14, 2020
andrewpbrett added a commit that referenced this issue Jul 16, 2020
@andrewpbrett
Merge pull request #93 from krugerk/bugfix/today-widget-rarely-expanded
fcc79a3 
[#92] fix today widget's bias toward compact view
@krugerk krugerk closed this as completed Jul 16, 2020
@krugerk krugerk linked a pull request Jul 16, 2020 that will close this issue
[#92] fix today widget's bias toward compact view #93
Merged
@krugerk krugerk self-assigned this Aug 8, 2020
@krugerk krugerk mentioned this issue Aug 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krugerk krugerk

Labels
BUG Opposite of feature PEA Easy-peasy STY Style / polish / CSS / pigsty / eyesore UVI Will count as a User-Visible Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#92] fix today widget's bias toward compact view
1 participant
@krugerk