Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #100 - sorting by recent data works #101

Merged
merged 1 commit into from
Jul 30, 2020
Merged

fix #100 - sorting by recent data works #101

merged 1 commit into from
Jul 30, 2020

Conversation

krugerk
Copy link
Contributor

@krugerk krugerk commented Jul 27, 2020

sorting by recent data failed because the date format specified
when parsing the lasttouch string did not match the format
provided by the server.

@krugerk
fix #100 - sorting by recent data works
190c24b 
sorting by recent data failed because the date format specified
when parsing the lasttouch string did not match the format
provided by the server.
@krugerk krugerk added BUG Opposite of feature PEA Easy-peasy UVI Will count as a User-Visible Improvement labels Jul 27, 2020
@krugerk krugerk requested a review from andrewpbrett July 27, 2020 09:45
@krugerk krugerk linked an issue Jul 27, 2020 that may be closed by this pull request
sorting gallery by recent data appears broken #100
Closed
andrewpbrett
andrewpbrett approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@andrewpbrett andrewpbrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@andrewpbrett andrewpbrett merged commit e3ff559 into beeminder:master Jul 30, 2020
@krugerk krugerk deleted the bugfix/100-sorting-by-recentdata-is-broken branch August 1, 2020 11:01
@krugerk krugerk added needs tests and removed BUG Opposite of feature labels Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewpbrett andrewpbrett andrewpbrett approved these changes

Assignees
No one assigned
Labels
PEA Easy-peasy UVI Will count as a User-Visible Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sorting gallery by recent data appears broken
2 participants
@krugerk @andrewpbrett