Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the thumbnail placeholder image in today widget #104

Merged
merged 1 commit into from
Jul 30, 2020
Merged

use the thumbnail placeholder image in today widget #104

merged 1 commit into from
Jul 30, 2020

Conversation

krugerk
Copy link
Contributor

@krugerk krugerk commented Jul 29, 2020

same as is used in the gallery inside the app

without the area remains blank

krugerk
krugerk commented Jul 29, 2020
View reviewed changes
Copy link
Contributor Author

@krugerk krugerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L178 sets the image as well and is currently without the placeholder.

@krugerk
[#104] use the thumbnail placeholder image in today widget
4b48f42 
same as is used in the gallery inside the app

without the area remains blank
also enable transition when swapping out placeholder with graph
@andrewpbrett andrewpbrett merged commit c2a34b4 into beeminder:master Jul 30, 2020
@krugerk krugerk deleted the bugfix/use-placeholder-image-in-todaywidget branch July 31, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewpbrett andrewpbrett andrewpbrett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krugerk @andrewpbrett