use SafariViewController for creating new goals #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously a button was displayed for users with any goals, which would open a view controller at which point a webview was used to load the 'create goal' section of the beeminder website considering the app is not customizing the website it need not use a webview
andrewpbrett
approved these changes
Aug 4, 2020
krugerk
deleted the
feature/use-safariviewcontroller-for-new-goals-in-browser
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously a button was displayed for users with
any goals, which would open a view controller
at which point a webview was used to
load the 'create goal' section of the beeminder
website
considering the app is not customizing the website
it need not use a webview