Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #85 health app integration vc cleanup #122

Merged
merged 18 commits into from
Aug 11, 2020
Merged

fix #85 health app integration vc cleanup #122

merged 18 commits into from
Aug 11, 2020

Conversation

krugerk
Copy link
Contributor

@krugerk krugerk commented Aug 3, 2020

resolves #85

@krugerk krugerk requested a review from andrewpbrett August 6, 2020 22:01
krugerk
krugerk commented Aug 9, 2020
View reviewed changes
BeeSwift/HealthKitConfigTableViewCell.swift Show resolved Hide resolved
BeeSwift/HealthKitConfigViewController.swift Show resolved Hide resolved
BeeSwift/HealthKitConfigViewController.swift Outdated Show resolved Hide resolved
BeeSwift/HealthKitConfigViewController.swift Outdated Show resolved Hide resolved
BeeSwift/RemoveHKMetricViewController.swift Outdated Show resolved Hide resolved
BeeSwift/RemoveHKMetricViewController.swift Outdated Show resolved Hide resolved
krugerk and others added 18 commits August 10, 2020 12:51
@krugerk
[#85] sort A to Z on healthkit config
a12510c
@krugerk
[#85] three sections in healthKitConfig
c906f39 
topmost - manual/editable
middle - auto but apple thus editable in the app
bottommost - auto and not apple and thus not editable in the app
@krugerk
[#85] header for three sections of healthkitconfig table
a09235b
@krugerk
[#85] pull-to-refresh on healthkitconfigvc
8964ceb
@krugerk
[#85] some spacing on the healthkitconfig screen
44418e3
@krugerk
[#85] text alignment in HKConfigTable
752964b
@krugerk
[#85] mention slug on remove HKMetric screen
9fc957f
@krugerk
varget for humanizedAutoData instead of func
c333718
@krugerk
notification for removing healthKitMetric from goal
d8f4066
@krugerk
address swift 4.2 warning on implicitlyUnwrappedOptional
72ae361
@krugerk
#85 present a sorted list of healthkit metrics
1d458bc 
when choosing a metric for a goal, the list
of metrics is now sorted alphabetically
(previously they were displayed in whichever order
they had been added to the HealthKitConfig
helper)
@krugerk
address swift 4.2 warning on implicitlyUnwrappedOptional
427a080
@krugerk
#85 goal is no longer optional in ChooseHKMetricVC
c502e44
@krugerk
#85 provide some basic instructions when adding a metric to a goal
97bf5aa 
mention which goal,
explain a little how the process works,
and instruct the user to save changes
@krugerk
matching titles for choose and remove metric
02a4b60
@krugerk
clean code
c95066e 
prefer let over var set only once a line later
@krugerk
matching attributedText for removeHKMetric
c9b9162
@andrewpbrett
Update copy on Healthkit config controller
173adab
@andrewpbrett andrewpbrett merged commit 06e173e into beeminder:master Aug 11, 2020
@krugerk krugerk deleted the bugfix/85-health_app_integration_VC_cleanup branch August 11, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewpbrett andrewpbrett andrewpbrett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

health app integration VC cleanup
2 participants
@krugerk @andrewpbrett