Make Goal mutable and able to be updated #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We wish to be able to re-initialize goal based on new data. If the new data has values missing we should unset the appropriate values in the structure, rather than persisting the old values. Thus we remove conditionals and instead allow nils to be set. Test Plan: * Confirmed app loads and shows gallery in simulator
Goal objects now expose a way to update their values from new JSON. This does not allow the goal ID to change (though the slug could, as beeminder allows you to rename goals).
Ideally we would make this an actor, but lots of its methods need to be called synchronously
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally
Goalobjects were immutable and replaced on change. However, as we move towards an architecture where there are objects which keep references to goals, it makes more sense to have them be mutable and updated (and ideally with only one instance per goal). This was somewhat true before, but has become more explicit with recent changes.Here we allow goals to be refreshed, update some controllers to use this functionality, and address some resulting concurrency issues.
Test Plan:
Smoke test running locally for a while