Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show lemniscate for queued goals #444

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

theospears
Copy link
Collaborator

Goals in beeminder can be in a queued state. This means while the client has the latest server data, the server has processing to do to update the state of the goal. Previously this state was not surfaced in the app. Here we update the app to show an animated bee over the graph when in this state. This matches the website behavior.

Some refactoring is done to aid with this. A new component is introduced to render the lemniscate, and a new image view is introduced to consistently show the goal image, placeholder, and lemniscate, when appropriate. Some of the state machines here are somewhat intricate.

Testing:

  • Refreshed goals in the app and saw the goal view behaved as expected
  • Refreshed goals and the gallery view and observed they behaved as expected

Known bugs:

  • When the gallery view refreshes, the lemniscate can skip between locations in the animation
  • We trigger a graph update, and thus the lemniscate, when refreshing goals which do not have autodata

@theospears
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @theospears and the rest of your teammates on Graphite Graphite

@theospears theospears merged commit 63784af into master Feb 22, 2024
2 checks passed
@theospears theospears deleted the queued-state-indicator branch February 22, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant