Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refreshing gaols should only trigger a graph refresh for autodata goals #446

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Refreshing gaols should only trigger a graph refresh for autodata goals #446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion BeeSwift/GoalViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,9 @@ class GoalViewController: UIViewController, UIScrollViewDelegate, DatapointTabl
do {
if self.goal.isLinkedToHealthKit {
try await ServiceLocator.healthStoreManager.updateWithRecentData(goal: self.goal, days: 7)
} else {
} else if goal.isDataProvidedAutomatically {
// Don't force a refresh for manual goals. While doing so is harmless, it queues the goal which means we show a
// lemniscate for a few seconds, making the refresh slower.
try await ServiceLocator.goalManager.forceAutodataRefresh(self.goal)
}
try await self.updateGoalAndInterface()
Expand Down