Show goals in Spotlight #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @theospears and the rest of your teammates on |
krugerk
reviewed
Aug 10, 2024
| class BeeminderSpotlightDelegate: NSCoreDataCoreSpotlightDelegate { | ||
|
|
||
| override func attributeSet(for object: NSManagedObject) -> CSSearchableItemAttributeSet? { | ||
| if let goal = object as? Goal { |
There was a problem hiding this comment.
Prefer swift's guard here?
There was a problem hiding this comment.
The examples in the docs choose this approach because it scales nicely to multiple different types. It's unclear what other types beeswift might want to index though, so I'm leaning towards "either would be fine"
| @@ -171,7 +174,11 @@ class AppDelegate: UIResponder, UIApplicationDelegate, UNUserNotificationCenterD | |||
| UNUserNotificationCenter.current().removeAllPendingNotificationRequests() | |||
| } | |||
| func application(_ application: UIApplication, continue userActivity: NSUserActivity, restorationHandler: @escaping ([UIUserActivityRestoring]?) -> Void) -> Bool { | |||
| if let intent = userActivity.interaction?.intent as? AddDataIntent { | |||
| if userActivity.activityType == CSSearchableItemActionType { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the integration between CoreData and Spotlight to make goal information available in spotlight search.
Testing:
Ran on device and saw the entries appear in spotlight
Verified clicking on items navigates to the app