Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HealthKit should not remove metadata datapoints #474

Merged
merged 2 commits into from
Sep 14, 2024
Merged

Conversation

theospears
Copy link
Collaborator

@theospears theospears commented Sep 14, 2024

The HealthKit integration deletes all points which do not correspond to HealthKit entries. In the past this resulted in deleting points used for metadata tracking, e.g. derailments or restarts. This was confusing for support.

Resolve this by ignoring those points when syncing with HealthKit, so they are neither updated nor deleted.

Fixes #456

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @theospears and the rest of your teammates on Graphite Graphite

@theospears theospears changed the title Extract out metapoint logic HealthKit should not remove metadata datapoints Sep 14, 2024
@theospears theospears marked this pull request as ready for review September 14, 2024 22:00
@theospears theospears merged commit 0f6a3ae into master Sep 14, 2024
3 checks passed
@theospears theospears deleted the meta-data-points branch September 14, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't delete the #DERAIL datapoint
1 participant