Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blemish in BSButton's corners #488

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

krugerk
Copy link
Contributor

@krugerk krugerk commented Oct 6, 2024

This addresses the blemish as seen in the screenshot in #483 (comment). A square border is drawn around an otherwise rounded button. Now the border is also rounded.

Dark

Before

Simulator Screenshot - Test-iPhone - 2024-10-06 at 13 48 52

After

Simulator Screenshot - Test-iPhone - 2024-10-06 at 14 09 05

Light

Before

Simulator Screenshot - Test-iPhone - 2024-10-06 at 13 48 47

After

Simulator Screenshot - Test-iPhone - 2024-10-06 at 14 09 30

Copy link
Collaborator

@theospears theospears left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@theospears
Copy link
Collaborator

Do you think we should move towards rounded corners for the text fields too?

@theospears theospears merged commit 23d5bcf into beeminder:master Oct 6, 2024
1 check passed
@krugerk krugerk deleted the blemish-in-rounded-button branch October 11, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants