Lighter button fill in light mode

[krugerk]

Provides a lighter fill color for the button when in light mode and handles updating it dynamically as the appearance changes.

Examples:

Light

Dark

[krugerk]

contains changes from PRs #487 and #486

[theospears]

As this is duplicated in both init methods, perhaps it should instead live in setUp?

[theospears]

I wonder what it would look like if we used the same grey as the +/- buttons. Possibly too low contrast with the yellow?

[krugerk]

I think you are right. The contrast seems to work for me on the sign in button but looks too low contrast elsewhere.

How about something like this - yellow on black in dark and black on grey in light mode?

yellowonblacktoblackongrey.mp4

[theospears]

What if we skipped the border entirely and just had the solid button, either gray or yellow?

[theospears]

Grey (OK):

Yellow + Black Text (Probably too loud):

Yellow + White Text (Unreadable):

[theospears]

And for completeness, default system blue:

[krugerk]

And the current target? Yellow text on Black background with yellow border in dark mode and black text on grey and without border in light mode?

[theospears]

My take would be:

• Yellow border and text, black background when shown in dark mode
• Black on grey without border in light mode

But I don't feel like I have particularly good graphics design taste, so I'm happy for you to make a call on what you want to try, and we can put it out to test flight to get wider feedback.