Avoid keyboard obscuring last goals in gallery view #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krugerk
reviewed
Dec 2, 2024
| @@ -147,7 +147,7 @@ class GalleryViewController: UIViewController, UICollectionViewDelegateFlowLayou | |||
| make.top.equalTo(self.searchBar.snp.bottom) | |||
| make.left.equalTo(self.view.safeAreaLayoutGuide.snp.leftMargin) | |||
| make.right.equalTo(self.view.safeAreaLayoutGuide.snp.rightMargin) | |||
| make.bottom.equalTo(0) | |||
| make.bottom.equalTo(self.collectionView!.keyboardLayoutGuide.snp.top) | |||
There was a problem hiding this comment.
looks great! 👏
This one line using this iOS 15 feature sure beats out the manual 27 line approach in #503.
(bothers me that we have another use of collectionView! - we could just mark it as such at Line 23 and not have to do it anywhere else instead of doing it everywhere else, though obviously this is not directly related to adjusting the view's bottom to handle the keyboard)
|
This one then fixes #200 |
This was referenced Dec 2, 2024
theospears
pushed a commit
that referenced
this pull request
Dec 10, 2024
## Summary space could have been allocated for a keyboard that was not shown when returning to the gallery from a goal with the keyboard shown follow-up to #536
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously when using the goal filter, the keyboard would obscure the last goals in the list. Here we make the scrollview resize itself to only take up the section of screen above the keyboard so you can always scroll to the bottom.
This is an alternative approach to #503
Validation
Loaded the gallery view on device