show placeholder graph right away #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a placeholder image is being used until the goal is loaded however this is set relatively late - in `viewDidAppear`, which means the user sees the view containing a large white/blank area where the graph will appear, then sees the placeholder, then sees the updated graph with this change, the placeholder is set right straight away and thus is seen as the goalVC is being slid into view
andrewpbrett
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a placeholder image is being used until the goal is loaded however this is set relatively late - in
viewDidAppear, which means the user sees the view containing a large white/blank area where the graph will appear, then sees the placeholder, then sees the updated graphwith this change, the placeholder is set right straight away and thus is seen as the goalVC is being slid into view