This repository has been archived by the owner on Nov 9, 2022. It is now read-only.
new: Initial support for PnP. #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
reviewed
Jul 13, 2021
Comment on lines
+351
to
+352
| * of its dependencies. This functionality is necessary to satisfy Yarn PnP and | ||
| * resolving plugins that aren't listed as direct dependencies. |
There was a problem hiding this comment.
NIT: It's required regardless of PnP, otherwise it's depending on hoisting which isn't guaranteed to be in its favour, e.g. workspaces.
https://yarnpkg.com/advanced/rulebook#packages-should-only-ever-require-what-they-formally-list-in-their-dependencies
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been working on supporting PnP in Boost, which also requires work here. It's a vicious circle.
The biggest blocker is loading plugins/configs.