-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardcode software_name to "macOS" #11
Conversation
- on macOS 10.15 and earlier, the software_name reports as "Mac OS X" and this breaks reteival of albert push cert causing Beeper Mini to crash after entering registration code.
The current "quick fix" for 10.14.6 and below (not contained in this PR) is to remove the The change in this PR DOES allow Catalina to work, with no further changes. If no one submits a PR to fix handling in 10.14 and below, I'll try to fix it myself when I have a bit more time. |
It might be more correct to fix this hack: https://github.com/beeper/imessage/blob/main/imessage/direct/albert/activationinfo.go#L74, in other places where the software name is used, it's probably actually supposed to be |
Possibly! That line of code would certainly explain things failing, as there was no logic to handle I had mentioned this issue and my "workaround" in the pypush discord and another user tried grabbing the cert "manually" while using "Mac OS X" as their DeviceClass and that also failed.. so it's possible it may need something else like |
- this properly addresses the issue first addressed in beeper/mac-registration-provider#11 when using macOS devices prior to Big Sur
@tulir and an update to my mention of things not working on 10.14.6 or earlier -- I've realized this is due to |
- this properly addresses the issue first addressed in beeper/mac-registration-provider#11 when using macOS devices prior to Big Sur
macOS 11+ reports
software_name
as "macOS".With software_name reporting as "Mac OS X" the following error can been seen in logcat:
com.beeper.chat.booper.ipc.BridgeCrashedException: {"level":"fatal","error":"failed to generate albert push certificate: failed to decode device cert","time":"2023-12-28T12:58:40.124078741Z","message":"Failed to configure iMessage"}
Once mac-registration-provider is re-built with the
software_name
"spoofed" to "macOS", the issue is gone and the app then prompts for Apple ID sign-in.It may be best to set this hardcoded value on the Beeper/Beeper Mini side of things... but, for now, this specific code change allows Beeper Mini to register while running this binary on macOS 10.15.x.
Additional changes in versions.go for macOS 10.14 and below will be needed as the current error handling with
panic
causes the binary to fail as the various commands to obtain hardware/software info fail on macOS 10.14 and earlier.