feat: 리뷰 등록 step 1,2,3 페이지 구현 #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hy57in
force-pushed
the
feat/create-review-1
branch
from
fff49ea
to
62e7ef9
Compare
hoo00nn
reviewed
Feb 12, 2023
| const { mutateAsync: createReviewMutation } = useMutation(postReview); | ||
| const { mutateAsync: createReviewMutation } = useMutation(createReview); |
There was a problem hiding this comment.
mutation도 한 번 래핑해서 사용하는건 어떠신가요?
export const useCreateReviewMutation = () => {
const cache = useQueryClient();
const { mutateAsync: createReviewMutation, ...rest } = useMutation(createReview, {
onSuccess: async () => {
await cache.invalidateQueries(queryKeyFactory.GET_REVIEW);
},
});
return {
createReview: createReviewMutation,
...rest,
};
};There was a problem hiding this comment.
useGetReviewsByBeer 도 queryKey를 queryKeyFactory에서 가져오는 방식으로 변경하는거 어떨까요!?
ref
There was a problem hiding this comment.
Open
hoo00nn
reviewed
Feb 13, 2023
src/apis/review/createReview.ts
Outdated
|
|
||
| const { mutateAsync: createReviewMutation, ...rest } = useMutation(createReview, { | ||
| onSuccess: async () => { | ||
| await cache.invalidateQueries(queryKeyFactory.CREATE_REVIEW()); |
There was a problem hiding this comment.
리뷰 생성되고 호출되는 success 함수 내부에서는 리뷰 리스트를 invalidate 시켜야하지 않나요..?
There was a problem hiding this comment.
아핫..! 리뷰 리스트를 invalidate 하는 것으로 수정했습니다. 리뷰 감사합니다 🫢
hoo00nn
approved these changes
Feb 13, 2023
syoung125
approved these changes
Feb 19, 2023
| @@ -97,12 +97,12 @@ const BeerTicketTitle: React.FC<BeerTicketTitleProps> = ({ | |||
| {sliceAndUpperCase(beer?.country?.engName || 'non', 3)} | |||
| </span> | |||
| <div className="ticket-detail"> | |||
| {`${beer?.alcohol?.toFixed(1)}%`} | |||
| {beer?.alcohol ? `${beer.alcohol?.toFixed(1)}%` : '-'} | |||
There was a problem hiding this comment.
'?' 없어도 괜찮을 것 같아요!
Suggested change
| {beer?.alcohol ? `${beer.alcohol?.toFixed(1)}%` : '-'} | |
| {beer?.alcohol ? `${beer.alcohol.toFixed(1)}%` : '-'} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📍 주요 변경사항
🔗 참고자료
💡 중점적으로 봐주었으면 하는 부분