embedart: Error on non-existent -f file

Fixes #1252.
beetbox · Jan 21, 2015 · 433d6b7 · 433d6b7
1 parent e0a48c6
commit 433d6b7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/beetsplug/embedart.py b/beetsplug/embedart.py
@@ -68,6 +68,10 @@ def commands(self):
         def embed_func(lib, opts, args):
             if opts.file:
                 imagepath = normpath(opts.file)
+                if not os.path.isfile(syspath(imagepath)):
+                    raise ui.UserError(u'image file {0} not found'.format(
+                        displayable_path(imagepath)
+                    ))
                 for item in lib.items(decargs(args)):
                     self.embed_item(item, imagepath, maxwidth, None,
                                     compare_threshold, ifempty)

diff --git a/docs/changelog.rst b/docs/changelog.rst
@@ -44,6 +44,8 @@ Fixes:
 * :doc:`/plugins/embedart`: Handle errors in ImageMagick's output. :bug:`1241`
 * :doc:`/plugins/keyfinder`: Parse the underlying tool's output more robustly.
   :bug:`1248`
+* :doc:`/plugins/embedart`: We now show a comprehensible error message when
+  ``beet embedart -f FILE`` is given a non-existent path. :bug:`1252`
 
 For developers: